search

ddeboer / vatin

Validate VAT identification numbers
MIT License
136 stars 37 forks source link

Change property visibility and make SOAP client options configurable for VIES client #27

Open fnagel opened 6 years ago

fnagel commented 6 years ago

We want to change the URL address and add a SOAP client timeout.

It would be helpful if the $wsdl property would be changed to protected (in order to extend the class and change the property) and if the options passed into the \SoapClient (second parameter) would be configurable using a protected property.

Related file is ddeboer/vatin/src/Vies/Client.php

ddeboer commented 5 years ago

It would be helpful if the $wsdl property would be changed to protected

Is this necessary? You should be able to call parent::__construct($wsdl).

if the options passed into the \SoapClient (second parameter) would be configurable using a protected property.

Good point. What about adding the SoapClient options as a second constructor argument to Client?