Closed dffyfe closed 2 years ago
This seems to happen only when a patient without any prescription in the window is plotted alongside another one that does... I'll look into it anyways
(BTW, data = CMAExamplesSpace
should be data = CMAExampleSpace
:))
Hi, yeah probably more relevant to my use case (using drugs as patients) than others. It's happening because plotids
and cmas
is unfiltered in the vert.space.cmas
calc, I think.
No worries: so, I'm trying to still plot the empty ones, but would you rather prefer not to plot them at all?
... personally I think it still informative to see them, even with empty bars and "?" estimates
Like this:
I prefer them plotted too.
I think this line in plotting.R needs removed if they are to be kept;
cma$data <- cma$data[ !(cma$data[,col.patid] %in% patids.no.events.to.plot), ];
As a workout for CMA10 and 11 I used used return(0) rather than return(CMAReal) so it would always plot as 0%, but '?' makes more sense.
so the above plot is ok for you? If so, I'll fix it so...
Yeah the above is best I would say!
22 Nov 2021 09:31:45 Dan Dediu @.***>:
so the above plot is ok for you? If so, I'll fix it so...
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub[https://github.com/ddediu/AdhereR/issues/174#issuecomment-975326997], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ARVBNWQLDFC7KY7VHCUQ2I3UNIEYDANCNFSM5ICAENXA]. Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAD8AAAA/CAYAAABXXxDfAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAmSURBVGiB7cEBDQAAAMKg909tDwcUAAAAAAAAAAAAAAAAAAAAJwY+QwABivJx1AAAAABJRU5ErkJggg==###24x24:true###][Tracking image][https://github.com/notifications/beacon/ARVBNWS4GSXO2XK5I7UWYF3UNIEYDA5CNFSM5ICAENXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHIRE6FI.gif]
should be fixed in the devel
brach
Hi Dan,
When there is no CMA available and the partial CMA bar isn't being plotted, the size of the plot isn't adjusted to fit. I also think the positioning of the y-axis might be off but not 100%. Reprex below;