search

ddelnano / packer-plugin-xenserver

A builder plugin for Packer.IO to support building XenServer images.
Mozilla Public License 2.0
72 stars 37 forks source link

Remove iso checksum type and fix tests #48

Closed somerandomqaguy closed 1 year ago

somerandomqaguy commented 1 year ago

Remove iso_checksum_type checks

This aligns the Xenserver plugin to being a bit more inline with what Packer > 1.6.0 is expecting, since packer now simply ignores the iso_checksum_type (it's supposed to error out but that code path isn't working right now because we don't set PluginType in the configs. The unit tests have been altered to reflect this reality.

Note that this isn't a comprehensive change; the config still has the inert ISOChecksumType, and there's probably a laundry list of other things that needs to be looked at, For now though, we have working unit tests again.

Documentation has been updated to reflect this new change as well.

ddelnano commented 1 year ago

Greatly appreciate you taking the time to improve the packer plugin! I've been behind on reviewing the recent PRs for this project, but I plan to look at this within the next week or two!

ddelnano commented 1 year ago

@somerandomqaguy I'm extremely sorry this took so long to follow up on. I've added a few changes on top of your original change to fully remove iso_checksum_type entirely in #60.

I really appreciate your contribution and I should be more responsive for this repo in the future now that I'm more actively using it.