ddelnano / packer-plugin-xenserver

A builder plugin for Packer.IO to support building XenServer images.
Mozilla Public License 2.0
72 stars 37 forks source link

Update builder documentation to include the missing (boot) `firmware` parameter #69

Closed justinkarabegovic closed 1 year ago

justinkarabegovic commented 1 year ago

Please add the option to select between bios and uefi boot firmware for the VM.

This could initially be added as an option to platform_args. This could then be migrated to a standalone argument later.

Perhaps could be implemented in:

File: https://github.com/ddelnano/packer-plugin-xenserver/blob/master/builder/xenserver/iso/builder.go

Line 84:

    if len(self.config.PlatformArgs) == 0 {
        pargs := make(map[string]string)
        pargs["viridian"] = "false"
        pargs["nx"] = "true"
        pargs["pae"] = "true"
        pargs["apic"] = "true"
        pargs["timeoffset"] = "0"
        pargs["acpi"] = "1"
        self.config.PlatformArgs = pargs
    }

add an additional option such as:

        pargs["hvm_boot_firmware"] = "bios"

Which would match parameter in https://github.com/terra-farm/terraform-provider-xenorchestra/blob/master/xoa/resource_xenorchestra_vm.go

ddelnano commented 1 year ago

@justinkarabegovic this is already possible in the latest release and was implemented in #39. I think the confusion here is that we forgot to update the docs to include that parameter.

ddelnano commented 1 year ago

Please let me know if you run into any issues using it, but I believe this is complete now.