search

ddelnano / packer-plugin-xenserver

A builder plugin for Packer.IO to support building XenServer images.
Mozilla Public License 2.0
72 stars 37 forks source link

Allow user to have a template or a full VM #94

Closed AtaxyaNetwork closed 11 months ago

AtaxyaNetwork commented 1 year ago

As i said in issue #89, this PR allow user to have a template or a full VM

In the .pkr.hcl file, you can add this to set the VM as a template

set_template = "True"

Tested on my side, it's working with the variable set and not set, but, if others can test, it would be great ! I'm not a go expert, so maybe my way it's not the best way to handle this

AtaxyaNetwork commented 1 year ago

I pushed the change you requested, so convert to template is now the default behavior. I also add documentation about skip_set_template, but I was not very inspired, so I'm not sure if it's very clear. I'm open to suggestion !

Modification was tested with "skip_set_template = true" and no variable set, and it's working as expected

AtaxyaNetwork commented 11 months ago

Hi @ddelnano ! Did you have time to review my last commit ?

Thank you !

ddelnano commented 11 months ago

@AtaxyaNetwork sorry for the late reply, I was traveling for work. This lgtm now and really appreciate the contribution! I'll try to get a release done within the next week.