Closed yonch closed 3 years ago
Thank you for the contribution! Does it need any changes in the CMakeLists.txt to build the new test?
I test manually by running go test
in the mba
folder, but it will be good to add to the CMakeLists.txt if it's part of your workflow -- I'll go ahead and add that
Thanks again!
thank you for the quick turnaround!! hope to contribute more in the future :)
Thank you for open-sourcing this implementation! It had been a pleasure to work with on a Python project.
I wanted to use MBA<2> in Golang, so wrote these wrappers using
cgo
...Verified using tests (in
golang_mba_test.go
):test_mba.cpp
interp
Python example in the README, the Golang test then expects to generate the exact same values for the same inputs.This implementation also support the functionality through Python's
__repr__
via theString()
function on the Mba2 struct.I hope to continue contributing further fixes or enhancements in case those come up.
Thanks again for open sourcing!