ddemidov / mba

Scattered data interpolation with multilevel B-Splines
MIT License
73 stars 23 forks source link

Add Go wrappers for MBA<2> #16

Closed yonch closed 3 years ago

yonch commented 3 years ago

Thank you for open-sourcing this implementation! It had been a pleasure to work with on a Python project.

I wanted to use MBA<2> in Golang, so wrote these wrappers using cgo...

Verified using tests (in golang_mba_test.go):

This implementation also support the functionality through Python's __repr__ via the String() function on the Mba2 struct.

I hope to continue contributing further fixes or enhancements in case those come up.

Thanks again for open sourcing!

ddemidov commented 3 years ago

Thank you for the contribution! Does it need any changes in the CMakeLists.txt to build the new test?

yonch commented 3 years ago

I test manually by running go test in the mba folder, but it will be good to add to the CMakeLists.txt if it's part of your workflow -- I'll go ahead and add that

ddemidov commented 3 years ago

Thanks again!

yonch commented 3 years ago

thank you for the quick turnaround!! hope to contribute more in the future :)

ddemidov commented 3 years ago

I have applied fixes for the go tests on travis-ci in 15cbf8de28de6a32f9b2f28568758032dd91d7a6 (the logs are here). Hope the fixes make sense.