search

ddemidov / mba

Scattered data interpolation with multilevel B-Splines
MIT License
74 stars 23 forks source link

Add `go.mod` for golang support #17

Closed yonch closed 3 years ago

yonch commented 3 years ago

Without a go.mod, a go get works:

go get -u github.com/ddemidov/mba
go: downloading github.com/ddemidov/mba v0.0.0-20210614144229-15cbf8de28de
go: github.com/ddemidov/mba upgrade => v0.0.0-20210614144229-15cbf8de28de

however go mod vendor shows:

go mod vendor
go: finding module for package github.com/ddemidov/mba
<package> imports
    github.com/ddemidov/mba: module github.com/ddemidov/mba@latest found (v0.0.0-20210614144229-15cbf8de28de), but does not contain package github.com/ddemidov/mba

This PR adds a minimal go.mod, and removes making an ephemeral go.mod with go mod init in .travis.yaml.

Not sure where travis is deployed, so patch tries to minimally disrupt the current travis flow.

yonch commented 3 years ago

just found this might not be ready to merge, checking..

yonch commented 3 years ago

looks like it is all set.

ddemidov commented 3 years ago

Thanks!

ddemidov commented 3 years ago

Had to switch to travis-ci.com, as travis-ci.org has been discontinued. The tests are failing there, because go.mod requires go 1.14, and they have 1.10 (I think I removed go.mod earlier because tests on travis-ci.org were failing for the same reason). I don't have experience with go, how critical is that? Is it ok to just require 1.10 in go.mod?

yonch commented 3 years ago

I don't see a reason not set 1.10 in go.mod.

before this PR, seems tests passed with 1.10's go mod init creating a go.mod, so should be ok.