Closed yonch closed 3 years ago
just found this might not be ready to merge, checking..
looks like it is all set.
Thanks!
Had to switch to travis-ci.com, as travis-ci.org has been discontinued. The tests are failing there, because go.mod requires go 1.14, and they have 1.10 (I think I removed go.mod earlier because tests on travis-ci.org were failing for the same reason). I don't have experience with go, how critical is that? Is it ok to just require 1.10 in go.mod?
I don't see a reason not set 1.10 in go.mod
.
before this PR, seems tests passed with 1.10's go mod init
creating a go.mod
, so should be ok.
Without a
go.mod
, ago get
works:however
go mod vendor
shows:This PR adds a minimal
go.mod
, and removes making an ephemeral go.mod withgo mod init
in.travis.yaml
.Not sure where travis is deployed, so patch tries to minimally disrupt the current travis flow.