Closed henryiii closed 6 years ago
This sounds nice, thanks for working on it! I am ok with bumping cmake to 3.1.
Help in listing the C++11 features VexCL uses appreciated
VexCL is compatible with VS2010, so that dictates the list of acceptable C++11 features.
I'm preparing a PR with some fixes for the Mac build, along with a couple of helper functions for setting up multiple targets in CMake. Along those lines, I'd like to bump up the CMake version at least to 3.1. In my case, I need it to fix the C++11 selection (which is hardcoded and incorrect at 0x currently). Here are the benefits for different CMake versions:
::
targets VexCL currently uses heavily, first version to properly support macOS (if min 3.0 or higher set)I'd really like to bump the version required to at least 3.1 (many scientific packages, like CERN's ROOT, are on 3.3 or 3.4 now). It's one line to install CMake almost anywhere, and can be done without admin privileges. (
pip install --user cmake
often works fine), so let me know if I could set it to a higher version in the PR.My proposal is to use compiler features from 3.1, which will allow 0x or 11 to be selected, and even overridden by users. (Help in listing the C++11 features VexCL uses appreciated ;) )
Also adding a few typo corrections to docs and example in docs.