updating prawn dependency

ddengler / prawn-grouping

A gem to add a more flexible grouping option to the prawn gem

https://github.com/ddengler/prawn-grouping

MIT License

14 stars 21 forks source link

updating prawn dependency #8

Closed giuseb closed 9 years ago

giuseb commented 9 years ago

Hello, thanks for your work on this important prawn functionality.

I forked the project and have successfully run the specs against the most recent version of prawn (1.3.0).

Would it make sense to update the gemspec accordingly?

Cheers, Giuseppe

ddengler commented 9 years ago

I just updated gemspec to support all versions >= 1.0.0. Can you try the current master branch within your project? I will update my internal projects to prawn 1.3 and release a new version to rubygems unless I run into other issues.

giuseb commented 9 years ago

Thanks, I will test master in my project over the next couple of days!

giuseb commented 9 years ago

Well, the current master produces in my project the same output as the 0.1.1 gem. Alas, it's not the expected output, when compared to my previous setup (prawn 1.0.0rc2, before built-in grouping was disabled). I will try to write a failing spec describing the issue I have encountered.

ddengler commented 9 years ago

If I understand correctly:

Dependency issue resolved
Another issue unrelated to this one #10

giuseb commented 9 years ago

yes, sorry for the confusion; issue #10 does not depend on prawn version. The behavior I reported is the same with prawn 1.0 and 1.3.

Thanks!