First class new GitHub UI support!

[zardoy]

fixes https://github.com/dderevjanik/github-vscode-icons/issues/40 fixes https://github.com/dderevjanik/github-vscode-icons/issues/39 fixes https://github.com/dderevjanik/github-vscode-icons/issues/42 closes https://github.com/dderevjanik/github-vscode-icons/issues/43

Current tests are failing, though I didn't touch them as new UI only available when logged in.

@dderevjanik I rly miss icons in new ui so if it don't get merged in within a few weeks I'll publish it to chrome extensions store https://chrome.google.com/webstore/detail/github-vscode-icons-updat/amefmmaoenlhckgaoppgnmhlcolehkho

New UI: Now icons everywhere!

Screenshots

New file list and sidebar: Commands pallete: And as a bonus (even github doesn't show icons in this location), File search: No support for: modules, symlinks, old-style files search (`t`) (will be removed soon)

[kdev]

Love this!!!

[zardoy]

@kdev would you mind helping me testing this?

[kdev]

Hey @zardoy, I'm up for some tests! 👍

[zardoy]

Okay, so you can either build it youself or I can attach extension zip once I update all icons from vscode-icons repo (they are pretty outdated).

[kdev]

I would prefer a zip of some sort

[zardoy]

@kdev I love testers!

And I finally managed to publish new npm version with svgs of vscode-icons and now made extension with latest vscode-icons icons:

chrome-github-vsci-1.24.zip

Feel free to provide feedback to let me know wether everything is good!

For example now https://github.com/bgrins/TinyColor has deno.lock icon, but it seems we don't support dark theme 🤔

[zardoy]

Was going to upload it chrome ext marketplace, but it seems I fogot to handle results of github.com/search, will fix

[kdev]

Any plans on bringing this to Firefox?

[zardoy]

Any plans on bringing this to Firefox?

Currently, it doesn't work with Firefox, I don't know why atm. Not sure how hard it would be to publish. I may look at all this later.

[kdev]

I ran the crx through https://www.extensiontest.com and got the results below

Results

``` { "compat": [], "errors": [ { "message": "\"/manifest_version\" must be <= 2", "description": "Your JSON file could not be parsed.", "locations": [ {} ] }, { "message": "\"/background\" is in an unsupported format.", "description": "\"/background\" is in an unsupported format.", "locations": [ { "file": "manifest.json" } ] }, { "message": "The extension ID is required in Manifest Version 3 and above.", "description": "See https://mzl.la/3PLZYdo for more information.", "locations": [ { "file": "manifest.json" } ] } ], "warnings": [ { "message": "Unsafe assignment to innerHTML", "description": "Due to both security and performance concerns, this may not be set using dynamic values which have not been adequately sanitized. This can lead to security issues or fairly serious performance degradation.", "locations": [ { "file": "content.js", "line": 1 }, { "file": "content.js", "line": 1 }, { "file": "content.js", "line": 1 }, { "file": "content.js", "line": 1 }, { "file": "popup.js", "line": 2 }, { "file": "popup.js", "line": 2 } ] }, { "message": "Error in no-unsanitized: Unexpected callable. Please report a minimal code snippet to the developers at https://github.com/mozilla/eslint-plugin-no-unsanitized/issues/new?title=unexpected%20SequenceExpression%20in%20normalizeMethodCall", "description": "Due to both security and performance concerns, this may not be set using dynamic values which have not been adequately sanitized. This can lead to security issues or fairly serious performance degradation.", "locations": [ { "file": "content.js", "line": 1 }, { "file": "content.js", "line": 1 }, { "file": "content.js", "line": 1 }, { "file": "content.js", "line": 1 } ] }, { "message": "Unsafe assignment to outerHTML", "description": "Due to both security and performance concerns, this may not be set using dynamic values which have not been adequately sanitized. This can lead to security issues or fairly serious performance degradation.", "locations": [ { "file": "content.js", "line": 1 }, { "file": "content.js", "line": 1 }, { "file": "content.js", "line": 1 }, { "file": "content.js", "line": 1 } ] }, { "message": "Unsafe call to e.insertAdjacentHTML for argument 1", "description": "Due to both security and performance concerns, this may not be set using dynamic values which have not been adequately sanitized. This can lead to security issues or fairly serious performance degradation.", "locations": [ { "file": "content.js", "line": 1 } ] } ] } ```

[zardoy]

I believe this thing is outdated, manifest v3 is supported by Firefox. I was using web-ext lint to validate the manifest and it was ok. I could install the extension without any warnings/errors, but the user script didn't start (defined in content_scripts), I need to figure out why it doesn't work (eg test with hello word script with the current v3 manifest format or smth like that)

[dantehemerson]

@zardoy First of all thanks for this update, It works great!

I just wanted to request the feature to support icons in the search results. Thanks in advance.

[zardoy]

I just wanted to request the feature to support icons in the search results. Thanks in advance.

here we go

[max06]

hey @zardoy - love your work!

Do you plan maintaining it for longer?

[zardoy]

hey @zardoy - love your work!

thx

Do you plan maintaining it for longer?

For this one - yes. But I'm a single dev 5 actively running projects so I don't have much time to think of code changes on other projects like this one, sorry. will focus on this one a and fix the breakage once I have time for it :)

[max06]

No worries, take your time! I'd love to support you but I'm afraid my dev-skills aren't even remotely enough for that.

[zardoy]

No worries, take your time! I'd love to support you but I'm afraid my dev-skills aren't even remotely enough for that.

Hey all! Sorry, completely forgot about this one, and no one reminded :( Now finally I'm here with all UI breakages fixed, enjoy!