search

ddetommaso / TobiiGlassesPyController

Tobii Pro Glasses 2 Python controller
GNU General Public License v3.0
56 stars 28 forks source link

Can we just depend on any `opencv-python` version (or none at all) ? #34

Open moooeeeep opened 1 year ago

moooeeeep commented 1 year ago

Is there a reason this package depends on these old but oddly specific versions of opencv-python and av?

install_requires=['netifaces', 'opencv-python==4.2.0.32', 'av==8.0.3'],

If not, I'd like to suggest to widen / remove the version specifiers.

As both deps are also not even imported in the installed package, maybe we could drop those entries from the setup.py altogether, and add a requirements.txt to the apps folder maybe?

ddetommaso commented 1 year ago

Hi @moooeeeep ,

thank you for the feedback and suggestion. Those requirements allow the provided examples to run smoothly. I agree with you, for the controller itself it would be nice to minimize the requirements to those really necessary.

I leave the issue open, to keep track of future developments.