fix: do not fail on `apt-get update`, cleanup - Githubissues

ddev / ddev-contrib

Contrib space for DDEV services, tools, snippets, and approaches.

Apache License 2.0

162 stars 162 forks source link

fix: do not fail on `apt-get update`, cleanup #245

Closed stasadev closed 1 month ago

stasadev commented 1 month ago

The Issue

https://github.com/ddev/ddev/pull/5623

We must not allow apt-get update to fail if some repository is down, because it can stop the webserver from starting.

How This PR Solves The Issue

Allows apt-get install to continue after a fail for apt-get update.

Removes:

ARG BASE_IMAGE
FROM $BASE_IMAGE

Replaces some ENV with ARG.

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes