search

ddev / ddev-gitpod-launcher

Launch any DDEV project with Gitpod
https://ddev.github.io/ddev-gitpod-launcher/
Apache License 2.0
12 stars 8 forks source link

Replace underscore with slash for reponame so ddev config --auto does… #13

Closed theodorosploumis closed 2 years ago

theodorosploumis commented 2 years ago

Some git repositories may contain an underscore _. This makes command ddev config --auto fail because underscore is not allowed for host names.

You can see this issue for example if you try to open repository https://github.com/goalgorilla/open_social.

As a quick fix I added a simple string replace for all underscores to simple slashes.

PS. This may be a problem with the main command ddev config --auto but since I could not touch the Go code there I made this small change here.

theodorosploumis commented 2 years ago

I was trying to "ddevify' the https://github.com/goalgorilla/open_social to find out this issue.

theodorosploumis commented 2 years ago

Let's close this PR totally. I need to create a clean PR.

rfay commented 2 years ago

All you had to do was to push (with a force) the already-approved change.

rfay commented 2 years ago

I see, you were using just the theodorosploumis/main branch and got it messed up with another PR. Make a new branch for every PR and things will come out better.

But all you have to do here is push https://github.com/drud/ddev-gitpod-launcher/pull/13/commits/0a25948696e13525e3628d0dc81ce51f80980f31 into theodorosploumis/main after rebasing to upstream/main. And if you want to make a different PR, make it with a new git branch.