search

ddev / ddev-gitpod-launcher

Launch any DDEV project with Gitpod
https://ddev.github.io/ddev-gitpod-launcher/
Apache License 2.0
12 stars 8 forks source link

Remove underscores in reponame to avoid issues with URL validations #15

Closed theodorosploumis closed 2 years ago

theodorosploumis commented 2 years ago

It is better to not rewrite the repo path when cloning but just override the ddev config --auto command. Could we use a fixed name for ddev project?

rfay commented 2 years ago

So you don't get in trouble again, please create a unique branch for every PR.

theodorosploumis commented 2 years ago

It's too late here and I do not have a clear mind. I messed things up a bit. Now I reverted the code to the initial idea and this PR is outdated. The old PR is valid though.

https://github.com/drud/ddev-gitpod-launcher/pull/13/files

rfay commented 2 years ago

Thanks for all the work on this!