ddev / ddev-gitpod-launcher

Launch any DDEV project with Gitpod
https://ddev.github.io/ddev-gitpod-launcher/
Apache License 2.0
12 stars 8 forks source link

Specified artifacts file in form doesn't actually pull the artifacts correctly #30

Closed ultimike closed 5 months ago

ultimike commented 5 months ago

I'm trying to use DrupalPod to launch a "ddevdemo" site with a pre-populated database and files directory.

The repositories are:

But, whenever I try to launch the site, the database and files directory are not automatically imported. I'm pretty sure I'm following the instructions from https://github.com/ddev/ddev-gitpod-launcher, but clearly I'm missing something...

thanks, -mike

rfay commented 5 months ago

Seems to work for me with the defaults.

Testing using https://ddev.github.io/ddev-gitpod-launcher/ with the defaults, https://github.com/ddev/d10simple and d10simple-artifacts. It worked fine with those. Take a look at the differences between yours and those.

Can you share the output of what you see happen with gitpod? Does it fail to download them? Something else?

ultimike commented 5 months ago

Yeah, I compared my repos with d10simple and it looks like the ddevdemo one is working fine, but when I add ddevdemo-artifacts, after Gitpod is fully launched, I end up on the Drupal installation screen...

-mike

rfay commented 5 months ago

I see it loading the database correctly when I try it, but get this, implying that the code or PHP version don't work righ:

The website encountered an unexpected error. Try again later.

Error: Call to a member function set() on null in Drupal\dynamic_page_cache\EventSubscriber\DynamicPageCacheSubscriber->onRequest() (line 145 of core/modules/dynamic_page_cache/src/EventSubscriber/DynamicPageCacheSubscriber.php).

call_user_func(Array, Object, 'kernel.request', Object) (Line: 111)

You can use ddev mysql in the ddevdemo directory to inspect the database easily. You'll see that there appear to be the right tables there, meaning they got loaded? 119 tables?

It's certainly interesting that my experience is completely different than yours. I'm getting the db loaded just fine, but can't run the site.

Ah, but I see it getting the wrong artifacts:

Checking out repository https://github.com/ultimike/ddevdemo Attempting to get artifacts from https://github.com/ddev/d10simple-artifacts Cloning into '/tmp/d10simple-artifacts'... remote: Enumerating objects: 15, done. remote: Counting objects: 100% (15/15), done.

Maybe there's something wrong with the form.

rfay commented 5 months ago

Here's the problem:

image
rfay commented 5 months ago

If I change the link to https://gitpod.io/#DDEV_REPO=https%3A%2F%2Fgithub.com%2Fultimike%2Fddevdemo,DDEV_ARTIFACTS=https%3A%2F%2Fgithub.com%2Fultimike%2Fddevdemo-artifacts/https://github.com/ddev/ddev-gitpod-launcher/

Now I see the correct:

Checking out repository https://github.com/ultimike/ddevdemo Attempting to get artifacts from https://github.com/ultimike/ddevdemo-artifacts Cloning into '/tmp/ddevdemo-artifacts'... remote: Enumerating objects: 7, done.

AND...

image
rfay commented 5 months ago

I imagine there's something wrong with https://github.com/ddev/ddev-gitpod-launcher/blob/main/docs/script.js ?

rfay commented 5 months ago

Thanks for the report (and the PR). I ended up using @shaal 's more extensive PR.

I manually tested and this is working fine now:

image image