ddev / ddev-gitpod-launcher

Launch any DDEV project with Gitpod
https://ddev.github.io/ddev-gitpod-launcher/
Apache License 2.0
14 stars 9 forks source link

Refactor computeLink function and event listeners, fixes #30 #32

Closed shaal closed 7 months ago

shaal commented 7 months ago

I updated the Pages settings of my repo, you can test it here - https://shaal.github.io/ddev-gitpod-launcher/

Notice that with this PR every keystroke immediately updates the link.

Fixes

rfay commented 7 months ago

Thanks so much for this. Does this mean that in the entire history of this ddev-gitpod-launcher it always failed and nobody ever reported the failure?

rfay commented 7 months ago

Gave you full privs on this repo.

rfay commented 7 months ago

But of course please see much simpler

Also please provide manual testing instructions.

shaal commented 7 months ago

@rfay I added now testing steps in the description

ultimike commented 7 months ago

Thanks to you both for fixing this :)

-mike