search

ddev / ddev-gitpod-launcher

Launch any DDEV project with Gitpod
https://ddev.github.io/ddev-gitpod-launcher/
Apache License 2.0
12 stars 8 forks source link

Update script.js to fix bug with artifacts URL, fixes #30 #33

Closed ultimike closed 5 months ago

ultimike commented 5 months ago

The Issue

See #30.

How This PR Solves The Issue

I think that all that is needed is an additional computeLink(); call, as I added in this PR, but additional testings by others is more than welcome.

Manual Testing Instructions

Use a custom repository and artifacts URL (not d10simple) and ensure it works.

-mike

rfay commented 5 months ago

But what about

?

rfay commented 5 months ago

Please add manual testing instructions as well. I don't remember how to manually test the form.

rfay commented 5 months ago

Gave you privs on this repo.

rfay commented 5 months ago

This can be previewed at https://htmlpreview.github.io/?https://github.com/ultimike/ddev-gitpod-launcher/blob/patch-2/docs/index.html

Thanks to https://stackoverflow.com/a/12233684/215713

Doesn't quite work though because the target repo is wrong in that case. It was a good idea.

Update: However, changing the generated URL to just use ultimike/ddevdemo and then using the changed URL seems like an adequate test, and it makes it launch. BUT, it doesn't work. And wow, gets an ancient version of DDEV?

Update: I edited the URL wrong. Another test URL will be https://gitpod.io/#DDEV_REPO=https%3A%2F%2Fgithub.com%2Fultimike%2Fddevdemo,DDEV_ARTIFACTS=https%3A%2F%2Fgithub.com%2Fultimike%2Fddevdemo/https://github.com/ddev/ddev-gitpod-launcher/

Finally, that worked. It was just editing the link this PR generated and changing the last bit.

rfay commented 5 months ago

Thanks for this! Used the more extensive

instead, future PRs and improvements are all welcome.

ultimike commented 5 months ago

Thanks for taking care of this!

-mike