ddev / ddev-gitpod-launcher

Launch any DDEV project with Gitpod
https://ddev.github.io/ddev-gitpod-launcher/
Apache License 2.0
12 stars 8 forks source link

fix: set project workspace in Gitpod VScode #39

Closed tyler36 closed 3 weeks ago

tyler36 commented 1 month ago

The Issue

Currently, ddev-gitpod-launch opens Gitpod with "/workspace/ddev-gitpod-launcher" set as the workspace root when using Gitpod VScode.

As a developer, I want the DDEV project as my workspace root.

How This PR Solves The Issue

This PR:

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Fixes #3

Release/Deployment Notes

tyler36 commented 1 month ago

IMO the overall best thing here is to check out the project into its own place in /workspace instead of checking it out into a subdirectory of ddev-gitpod-launcher. Do you think there's a way to do that?

Thats exactly what this PR does. Is it not working as expected?

Oh, I see. The manual steps in the description are wrong.

Manual testing

rfay commented 1 month ago

In that case it has nothing to do with vscode does it? I guess that's what confused me. You're doing a good thing for everything and everybody?

tyler36 commented 1 month ago

In that case it has nothing to do with vscode does it? I guess that's what confused me. You're doing a good thing for everything and everybody?

Now I am confused. 😄

This PR address an issue from #3 (ddev-gitpod-launcher and selecting VScode as the IDE) specificly the explorer panel. Using d9simple as an example for ddev-gitpod-launcher:

rfay commented 1 month ago

IMO it fixes much more than that :) because it fixes the confusion people have by it being in a subdirectory.

rfay commented 4 weeks ago

Sorry I didn't get back to this today, looking forward to testing it. Great leap forward!

tyler36 commented 3 weeks ago

What a great win!