ddev / ddev-gitpod-launcher

Launch any DDEV project with Gitpod

https://ddev.github.io/ddev-gitpod-launcher/

Apache License 2.0

12 stars 8 forks source link

Run composer install on project, don't try to import files/db if not exist #4

Closed rfay closed 2 years ago

rfay commented 2 years ago

Run composer install on project if it has composer.json
Don't try to import nonexistent files or db
Move start logic into a script (thanks @shaal )

Manual Testing Instructions

Use the launcher page to generate the beginning URL, https://rfay.github.io/ddev-gitpod-launcher/
Unfortunately the last bit of the URL has to reflect this PR. So if the generated link is https://gitpod.io/#DDEV_REPO=https%3A%2F%2Fgithub.com%2Frfay%2Fd9novendor/https://github.com/rfay/ddev-gitpod-launcher/ then replace the last part (the actual gitpod repo) with https://github.com/rfay/ddev-gitpod-launcher/tree/20211201_composer_install, so the link will become https://gitpod.io/#DDEV_REPO=https%3A%2F%2Fgithub.com%2Frfay%2Fd9novendor/https://github.com/rfay/ddev-gitpod-launcher/tree/20211201_composer_install
For the issue in #2 - fldc needing a composer install, https://gitpod.io/#DDEV_REPO=https%3A%2F%2Fgithub.com%2Fmherchel%2Ffldc22/https://github.com/rfay/ddev-gitpod-launcher/tree/20211201_composer_install

rfay commented 2 years ago

Please take a look @shaal - I've actually added you to the project so can formally ask for your review, but can't until you accept.