ddev / ddev-gitpod-launcher

Launch any DDEV project with Gitpod
https://ddev.github.io/ddev-gitpod-launcher/
Apache License 2.0
12 stars 8 forks source link

Update Gitpod ports #42

Open tyler36 opened 1 month ago

tyler36 commented 1 month ago

The Issue

I was debugging Mailpit issues in Gitpod when I noticed many of the ports are outdated.

How This PR Solves The Issue

This PR

This PR does NOT update the Mailpit port. See #40

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

tyler36 commented 1 month ago

Haven't had a chance to test it yet.

tyler36 commented 1 month ago

OK. Not sure what changes you would like here though.

rfay commented 1 month ago

There is no way to change it here, as it needs to be changed in DDEV.

But I'm not sure why it needs to be changed. Is it ddev mailpit that needs to be changed? What is the goal?

tyler36 commented 1 month ago

Consistency, mostly.

EG. Xdebug port:

rfay commented 4 weeks ago

Xdebug has been on 9003 for several years, since before gitpod support. I'm wondering how it got that?

If you can live with mailpit listening on 8027, it's OK there. People shouldn't have to know where these ports are.

rfay commented 4 weeks ago

Sorry, I got confused between your two PRs

tyler36 commented 3 days ago

So where are we with this?

stasadev commented 2 days ago

I think it's good.

Can you also add more ports from the official add-ons?:

tyler36 commented 1 day ago

Added ports but have not tested.

tyler36 commented 1 day ago

@stasadev Oops. Forgot the HTTP ports. Good catch!