search

ddev / ddev-gitpod-launcher

Launch any DDEV project with Gitpod
https://ddev.github.io/ddev-gitpod-launcher/
Apache License 2.0
14 stars 9 forks source link

Update ddev in gitpod.yml #44

Closed rfay closed 3 months ago

rfay commented 3 months ago

The Issue

We've been having to push a new image with DDEV bundled on every DDEV release, but it's really not necessary, and better to just do the upgrade here.

How This PR Solves The Issue

Do apt update and apt upgrade ddev

Manual Testing Instructions

See docs in https://github.com/ddev/ddev-gitpod-launcher#test-a-branch-of-this-repo

The branch is rfay:20240703_update_ddev: (https://github.com/rfay/ddev-gitpod-launcher/tree/20240703_update_ddev)

So:

  1. Visit https://ddev.github.io/ddev-gitpod-launcher/.
  2. Enter target repo.
  3. Copy the "Link used by "Open in Gitpod" button:" URL
  4. Replace https://github.com/ddev/ddev-gitpod-launcher/ with the branch path Eg. https://github.com/rfay/ddev-gitpod-launcher/tree/20240703_update_ddev

Actually, just use this link:

https://gitpod.io/?autostart=true#DDEV_REPO=https%3A%2F%2Fgithub.com%2Fddev%2Fd10simple,DDEV_ARTIFACTS=https%3A%2F%2Fgithub.com%2Fddev%2Fd10simple-artifacts/https://github.com/rfay/ddev-gitpod-launcher/tree/20240703_update_ddev

tyler36 commented 3 months ago

Upon open the provided link, it downloaded the "latest" DDEV images.

Download complete. 
v1.23.3: Pulling from ddev/ddev-webserver
6d753504a49b: Extracting [======================>                            ]  229.5MB/514.1MB

and correctly installed and configured Drupal (Umami page displayed).

tyler36 commented 3 months ago

My only concern is prebuilds; which probably doesn't affect anyone except me.

From my understanding, when a new commit is made to this repo, Gitpod triggers a rebuild of the workspace. This covers downloading the initial docker image, and commands in the init section, including downloading the DDEV images.

This PR updates DDEV as part of the init stage, so would be included in the prebuild. However, if we released a new DDEV version tomorrow, and I used the same link on Sunday, nothing would have changed in this repo to trigger a new prebuild right?

Most people aren't using prebuilds here though because they're not in ddev-gitpod-launcher's organization. I have/had an issue opened on DrupalPod because I don't get the rebuilds working. I like to use rebuilds though, so I updated my bookmarklet to use a fork of this repo so I can use rebuilds (which is why it probably only affects me).

rfay commented 3 months ago

AFAICT prebuilds don't work for anybody ever any more.

rfay commented 3 months ago

And the issue about them was closed; they have no intent of making them work.

rfay commented 3 months ago

Pulled, happy to look at this as time goes on. Next release of DDEV we will try not pushing the new image and we'll see what happens.

When I tested this, I saw the apt-get install -y ddev happen, there was no prebuild involved, and if there were a new version it would have gotten it.