Update artifacts repository automatically by default, fixes #5

ddev / ddev-gitpod-launcher

Launch any DDEV project with Gitpod

https://ddev.github.io/ddev-gitpod-launcher/

Apache License 2.0

12 stars 8 forks source link

Update artifacts repository automatically by default, fixes #5 #7

Closed rfay closed 2 years ago

rfay commented 2 years ago

Fixes

5
Add back a DDEV_ARTIFACTS field and send it in the URL
Update the back-end logic to respect it

Review

You can experiment with this at https://rfay.github.io/ddev-gitpod-launcher/

theodorosploumis commented 2 years ago

There were many suggestions so I created the PR #14. I do not know how to make suggestions from PRs. Will add my inline comments on PR #7.

rfay commented 2 years ago

Hi @theodorosploumis - The artifacts field can be empty, and it is only updated with a default, but can be edited or cleared. That was the suggested purpose of this PR.

To add suggestions to a PR, click the little suggestion icon when reviewing...

Update_artifacts_repository_automatically_by_default__fixes__5_by_rfay_·_Pull_Request__7_·_drud_ddev-gitpod-launcher

If you want to make a PR against the PR, you would make a PR against the rfay/20211201_add_artifacts branch. But it's better to talk about your differences than to just say you don't like it.