search

ddev / ddev-minio

MinIO addon for DDEV
Apache License 2.0
5 stars 0 forks source link

Use standard test technique with github action #39

Open rfay opened 4 months ago

rfay commented 4 months ago

Would you mind using the standard test technique, which uses https://github.com/ddev/github-action-add-on-test ?

That way the expectations of what runs and how it shows in the github API would be the same all the time.

It's so very easy, as in https://github.com/ddev/ddev-addon-template/blob/main/.github/workflows/tests.yml

seebeen commented 4 months ago

I wouldn't mind. Can we mod the action so it accepts extra args for bats. The current version does both the local and the repo pull test. Which is unnecessary on PRs and cron tests.

rfay commented 4 months ago

An issue to the github-action-add-on-test followed by a PR if the issue gets traction would be fine I'm sure. I imagine you're saying that on PRs and cron tests we don't need to do release tests? I don't think that's true, as the release tests are critical to ensure compatibility with the DDEV version.

rfay commented 4 months ago

I see today we have a successful scheduled test, https://github.com/oblakstudio/ddev-minio/actions, yay!

seebeen commented 4 months ago

I'm saying that when doing tests on PR - only the local test needs to be done. There is no need to run the release test via ddev get addon-org/addon-name. The official addon always does both the local and the remote test. I'll make a PR.