ddev / ddev-platformsh

Add integration with Platform.sh hosting service
Apache License 2.0
9 stars 10 forks source link

upstream value in `PLATFORM_ROUTES` is incorrect #124

Open gilzow opened 1 month ago

gilzow commented 1 month ago

the upstream value in a route object includes the upstream endpoint instead of just the upstream name

in ddev:

$ echo $PLATFORM_ROUTES | base64 --decode | jq
{
  "https://multisite-dir-demo.ddev.site/": {
    "primary": true,
    "id": null,
    "production_url": "<no value>",
    "attributes": {},
    "upstream": "bvdr:http",
    "type": "upstream",
    "original_url": "<no value>"
  }
}

vs in platform.sh

  "https://testdev-a57goni-x2uapu3x4o234.us-4.platformsh.site/": {
    "attributes": {},
    "id": null,
    "original_url": "https://{default}/",
    "primary": true,
    "production_url": "https://master-7rqtwti-x2uapu3x4o234.us-4.platformsh.site/",
    "type": "upstream",
    "upstream": "bvdr"
  },

in #64 the sample from ddev shows the correct upstream value so possibly a regression at some point?

rfay commented 1 month ago

I imagine if a regression, it would have been in

rfay commented 1 month ago

Discussion in https://platformsh.slack.com/archives/C03GRG19L2E/p1717184215113649