search

ddev / ddev-platformsh

Add integration with Platform.sh hosting service
Apache License 2.0
9 stars 10 forks source link

Set fail_on_hook_faiL: true, fixes #65 #77

Open rfay opened 1 year ago

rfay commented 1 year ago

DDEV's default these days is not to fail ddev start if a hook fails, but that doesn't seem quite right in the case of this add-on, where lots of complex things happen (imported from the platform hooks) and hidden failures can cause incomprehensible behavior.

This is an experiment at this point, but I think we should consider it. It will be interesting to see what tests it breaks.

rfay commented 1 year ago

6 of the 10 tests fail :(

rfay commented 1 year ago

This may be able to pass tests, but probably not until we load databases for all of them. For example, the Drupal hooks provided by platform require drush to run successfully, and it can't run without a database.