ddev / ddev-platformsh

Add integration with Platform.sh hosting service
Apache License 2.0
9 stars 10 forks source link

Support multi-app configuration (.platform.app.yaml isn't always in the root (and applications.yaml is a thing too)) #92

Open matthiaz opened 1 year ago

matthiaz commented 1 year ago

My test project does not have a .platform.app.yaml in the root folder, but in one of the subfolders

So when I try to get the plugin, it gives me an error

ddev get drud/ddev-platformsh
Downloading https://api.github.com/repos/drud/ddev-platformsh/tarball/v0.6.4 
v0.6.4_2589139534.tar.gz 99.83 KiB / ? [----------------------------------------------------------------------------------=---------------------------------------------------------------------------------------------------------------------] 1022.26% 0s 
unable to import yaml file /home/matthiasvanwoensel/PlatformSh/forest/.platform.app.yaml: unable to read file /home/matthiasvanwoensel/PlatformSh/forest/.platform.app.yaml (open /home/matthiasvanwoensel/PlatformSh/forest/.platform.app.yaml: no such file or directory) 

I believe this .platform.app.yaml is hardcoded here: https://github.com/drud/ddev-platformsh/blob/ae0bd9675aa20a7166411a7c1b0805a17a38ab8a/install.yaml#L312

Am I supposed to set the docroot to the folder where .platform.app.yaml lives? (I tried but it's not changing the error)

How would this handle the .platform/applications.yaml?

rfay commented 1 year ago

I didn't know that .platform.app.yaml could be elsewhere than in the root. I'm not sure we'll plan to deal with that case. Could you please link to docs explaining how it can be elsewhere than in the root?

gilzow commented 1 year ago

Docs for applications.yaml : https://docs.platform.sh/create-apps/multi-app.html#unified-app-configuration

matthiaz commented 1 year ago

https://docs.platform.sh/create-apps/multi-app.html

On Mon, 23 Jan 2023 at 17:12, Paul Gilzow @.***> wrote:

Docs for applications.yaml : https://docs.platform.sh/create-apps/multi-app.html#unified-app-configuration

— Reply to this email directly, view it on GitHub https://github.com/drud/ddev-platformsh/issues/92#issuecomment-1400608980, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA26OE26HBMIGVGY32RWMD3WT2UYRANCNFSM6AAAAAAUDUZPOQ . You are receiving this because you authored the thread.Message ID: @.***>

rfay commented 1 year ago

Thanks both - I guess the thing is we're explicitly not supporting multi-app setups in this add-on at this time.

gilzow commented 1 year ago

the applications.yaml can be used in a single application. As an example, we have it set up this way for the Django4 template.

I also believe .platform.app.yaml can be in a subfolder, even for a single application. Having said that, I don't believe it's that common.

@rfay maybe we need to call out in the readme that the add-on does not support multiapps

rfay commented 1 year ago

Oh, I thought the README already had that, thanks.

matthiaz commented 1 year ago

moh :(

On Mon, 23 Jan 2023 at 17:34, Randy Fay @.***> wrote:

Thanks both - I guess the thing is we're explicitly not supporting multi-app setups in this add-on at this time.

— Reply to this email directly, view it on GitHub https://github.com/drud/ddev-platformsh/issues/92#issuecomment-1400640166, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA26OEZMRFMSGMYCEM57KF3WT2XHRANCNFSM6AAAAAAUDUZPOQ . You are receiving this because you authored the thread.Message ID: @.***>

lolautruche commented 1 year ago

Don't worry @matthiaz it's in the roadmap 😉

apotek commented 5 months ago

Don't worry @matthiaz it's in the roadmap 😉

Definitely something me and my org would be interested in. This is a common scenario for us.

GeryDeMerciYanis commented 3 months ago

Looking forward for this feature too 👍