Closed rfay closed 1 year ago
Actually the solr start command already uploads security.json to zookeeper.
But I agree, that some more tests would be fine.
@rfay I can't get the tests to work. I don't find the the testdata directory. Could you take a look?
Happy to take a look, but would you mind rolling back to the working version and doing a PR with the new stuff?
https://github.com/mkalkbrenner/ddev-solr/commit/6b62fe72ede8cdb10cf9af7a4bb8a2340557355c was working, you can revert to it and then make a PR for what you're trying to do with the tests (or other things?). Then I'd be able to look at it more clearly.
I'm happy to do a debugging session with you as well, we could do a screenshare on discord. If you have time in the next 2 hours and could get the PR set up we can do this afternoon your time, or we could do it tomorrow afternoon your time.
@rfay I created #18
The problem is that https://github.com/mkalkbrenner/ddev-solr/blob/upload_test/tests/testdata/techproducts_configset.zip could not be loaded within the test.
@rfay any idea what needs to br done to access https://github.com/mkalkbrenner/ddev-solr/blob/upload_test/tests/testdata/techproducts_configset.zip within the tests?
Will see if I can take a look now that we got ddev v1.22.0-beta1 out. Thanks for your work on this!
@rfay thanks for your help. It works now 👍
Yay!
One detail is we should beef up the tests a bit to actually use zookeeper and the solr back-end just a bit. Right now it only checks to see if the Solr UI is functioning, which isn't a real thing.
Best situation:
It isn't necessary to do this before the promotion of this project to ddev org, but it will definitely make the tests more robust.