search

ddev / ddev-solr

Solr service for DDEV
Apache License 2.0
4 stars 5 forks source link

Move to ddev org #17

Closed rfay closed 9 months ago

rfay commented 1 year ago

This repo is ready to move to the ddev org.

When you're ready to move it @mkalkbrenner let me know and I'll give you permissions on github.com/ddevl and you can transfer it there, and then I'll transfer it to ddev.

Related:

mkalkbrenner commented 1 year ago

Thanks! We should do so after finishing the configset upload test in #13

rfay commented 1 year ago

I have invited you to the ddevl org as owner; you can move this there and I'll move it from there to the ddev org.

rfay commented 11 months ago

Hoping we can do this soon, all you have to do is transfer it, then I'll transfer it, then it needs a PR to change naming instances.

rfay commented 11 months ago

@mkalkbrenner you can just do the transfer any time. Looks like you accepted the invite OK, so you can just transfer to the ddevl org and I'll immediately transfer to ddev org.

mkalkbrenner commented 11 months ago

@rfay I have a question before doing the move. I just finished Solr 9 support for Drupal. It works with ddev by just changing this line: https://github.com/mkalkbrenner/ddev-solr/blob/ffe1c06c050d8ab46d98da94341822d80c8e445b/docker-compose.solr.yaml#L5

How do we deal with that in official add-ons? Do we need to provide different ones? One for Solr 8 and one for Solr 9? Or should we document to change docker-compose.solr.yaml?

rfay commented 11 months ago

There isn't a good technique yet. This is

Which is slated for upcoming work, DDEV v1.23. I don't exactly know how it should be done yet, interested in ideas.

It's easy enough to tell people right now to use a docker-compose.solr-9.yaml that overrides the image though, it should work. The problem is maybe what happens when they ddev get --remove solr and that one is still left there.

mkalkbrenner commented 11 months ago

I moved the project

rfay commented 11 months ago

Yay, it's moved. Now please fix it up to change the references to the project, and then do a new release.

rfay commented 11 months ago

And then we have to deprecate ddev-drupal9-solr and clear things up in its docs.

gitressa commented 9 months ago

The new add-on works perfectly, thanks @mkalkbrenner and @rfay! I made a PR (#25) to update the install path to use ddev/ddev-solr and the test path as well.

I hope https://github.com/ddev/ddev-drupal9-solr/ won't be removed, since many still use it?

rfay commented 9 months ago

Thanks, closing this. Thanks for the PR @gitressa - is there other cleanup to be done @mkalkbrenner ?

@gitressa can you suggest a good future for ddev-drupal9-solr? I could move it to my user (github redirects work great). We could just put a big USE ddev-solr IF YOU CAN at the top of its readme? If you have a suggestion, please PR it, thanks!