ddev / ddev-solr

Solr service for DDEV
Apache License 2.0
5 stars 5 forks source link

Unable to correctly update or remove add-on (missing #ddev-generated) #34

Closed rfay closed 4 months ago

rfay commented 4 months ago

Any add-on should be able to be updated or removed without doing anything but ddev get ... or ddev get --remove <addon>

However, lots of artifacts have been added to this that don't have the #ddev-generated comment in them, showing that it's safe to remove the file or update it.

Since there are so very many files, this may be a bit of a pain, but DDEV can't update or remove unless it knows that the files haven't been altered.

Here's what currently happens in this situation:

`ddev get` with `ddev get --remove` ``` ddev get ddev/ddev-solr Installing ddev/ddev-solr:0.4.0 Downloading https://api.github.com/repos/ddev/ddev-solr/tarball/0.4.0 0.4.0_1022620279.tar.gz 130.09 KiB / ? [-------------=----------------------------------------------------------] 1332.11% 1m1s Installing project-level components: πŸ‘ commands/solr/solr πŸ‘ commands/solr/solr-zk πŸ‘ docker-compose.solr.yaml πŸ‘ solr/configsets/.gitmanaged πŸ‘ solr/configsets/README.md πŸ‘ solr/configsets/techproducts/conf/_rest_managed.json πŸ‘ solr/configsets/techproducts/conf/_schema_analysis_stopwords_english.json πŸ‘ solr/configsets/techproducts/conf/_schema_analysis_synonyms_english.json πŸ‘ solr/configsets/techproducts/conf/currency.xml πŸ‘ solr/configsets/techproducts/conf/elevate.xml πŸ‘ solr/configsets/techproducts/conf/lang/contractions_ca.txt πŸ‘ solr/configsets/techproducts/conf/lang/contractions_fr.txt πŸ‘ solr/configsets/techproducts/conf/lang/contractions_ga.txt πŸ‘ solr/configsets/techproducts/conf/lang/contractions_it.txt πŸ‘ solr/configsets/techproducts/conf/lang/hyphenations_ga.txt πŸ‘ solr/configsets/techproducts/conf/lang/stemdict_nl.txt πŸ‘ solr/configsets/techproducts/conf/lang/stoptags_ja.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_ar.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_bg.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_ca.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_ckb.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_cz.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_da.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_de.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_el.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_en.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_es.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_et.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_eu.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_fa.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_fi.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_fr.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_ga.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_gl.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_hi.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_hu.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_hy.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_id.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_it.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_ja.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_lv.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_nl.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_no.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_pt.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_ro.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_ru.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_sv.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_th.txt πŸ‘ solr/configsets/techproducts/conf/lang/stopwords_tr.txt #ddev- πŸ‘ solr/configsets/techproducts/conf/lang/userdict_ja.txt πŸ‘ solr/configsets/techproducts/conf/managed-schema.xml πŸ‘ solr/configsets/techproducts/conf/mapping-FoldToASCII.txt πŸ‘ solr/configsets/techproducts/conf/mapping-ISOLatin1Accent.txt πŸ‘ solr/configsets/techproducts/conf/params.json πŸ‘ solr/configsets/techproducts/conf/protwords.txt πŸ‘ solr/configsets/techproducts/conf/solrconfig.xml πŸ‘ solr/configsets/techproducts/conf/spellings.txt πŸ‘ solr/configsets/techproducts/conf/stopwords.txt πŸ‘ solr/configsets/techproducts/conf/synonyms.txt πŸ‘ solr/configsets/techproducts/conf/update-script.js πŸ‘ solr/configsets/techproducts/conf/xslt/example.xsl πŸ‘ solr/configsets/techproducts/conf/xslt/example_atom.xsl πŸ‘ solr/configsets/techproducts/conf/xslt/example_rss.xsl πŸ‘ solr/configsets/techproducts/conf/xslt/luke.xsl πŸ‘ solr/configsets/techproducts/conf/xslt/updateXml.xsl πŸ‘ solr/lib/.gitmanaged πŸ‘ solr/lib/README.md πŸ‘ solr/security.json Installed DDEV add-on ddev/ddev-solr, use `ddev restart` to enable. Please read instructions for this add-on at the source repo at https://github.com/ddev/ddev-solr Please file issues and create pull requests there to improve it. Installed solr:0.4.0 from ddev/ddev-solr rfay@rfay-tag1-m1:~/workspace/d10$ ddev get --remove solr Unwilling to remove '/Users/rfay/workspace/d10/.ddev/solr' because it does not have #ddev-generated in it: signature was not found in file /Users/rfay/workspace/d10/.ddev/solr/configsets/.gitmanaged; you can manually delete it if it is safe to delete. Removed add-on solr ```