search

ddev / ddev-solr

Solr service for DDEV
Apache License 2.0
4 stars 5 forks source link

Tests are failing against stable (but not HEAD) #38

Closed rfay closed 1 month ago

rfay commented 1 month ago

tests are failing against stable. I don't know why they're not failing against HEAD.

Please fix, thanks @mkalkbrenner !

rfay commented 1 month ago

I'm not sure, but this could be related to https://github.com/ddev/github-action-add-on-test/pull/31

julienloizelet commented 1 month ago

Hi there, I see that the permissions are not the right ones to use v2: https://github.com/ddev/ddev-solr/blob/main/.github/workflows/tests.yml#L24

It should be actions:write .

Thanks

mkalkbrenner commented 1 month ago

The tests started to fail 2 days ago without any change to ddev-solr. In fact, the tests themselves don't fail.

@rfay As the yaml file is derived from the template, is there a fix for the template?

julienloizelet commented 1 month ago

For the past 2 days, the test action is trying to keep alive the repo on every run (using this keepalive action).

But the keepalive action needs actions:write permissions.

(Template has been modified: https://github.com/ddev/ddev-addon-template/blob/main/.github/workflows/tests.yml#L24)

rfay commented 1 month ago

Yay, fixed, thanks! https://github.com/ddev/ddev-solr/actions