search

ddev / ddev-ui

A not-currently-maintained user Interface that provides a graphical way of interacting with DDEV Local
https://www.ddev.com/
Apache License 2.0
20 stars 5 forks source link

Configuration of ddev path for ddev-ui #66

Open rfay opened 6 years ago

rfay commented 6 years ago

What happened (or feature request):

ddev-ui should use a trusted ddev version when it executes ddev. I think this would mean detecting the ddev in the path at initial config and asking the user for permission to use this, then storing it as config.

That brings up the issue that we need configuration of some type for ddev-ui, so this may drive that need.

It's possible that in the future we'll want to bundle ddev with ddev-ui. There are lots of tradeoffs in that.

What you expected to happen:

How to reproduce this:

Version: Please include the output of ddev version, docker version and the project's .ddev/config.yaml.

Anything else do we need to know:

Related source links or issues:

Please use a complexity rating of 1-5 (5 is high) for a feature request. (High complexity implies more PR planning)

cweagans commented 6 years ago

If we're going down this road, I'd like to also suggest that we save a sha1 of the ddev executable somewhere so that ddev-ui knows if the ddev executable has changed. This is inline with common TOFU patterns (i.e. ssh will alert you if a remote host key has changed).

rfay commented 6 years ago

Storing the key is a great idea, but doesn't necessarily account for the possibility of upgrading ddev without telling ddev-ui we're doing it.

cweagans commented 6 years ago

IMO, ddev-ui should notice that. A user confirmation should be expected behavior if ddev is updated.

andrew-c-tran commented 6 years ago

tagging this as a possible solution to lack of windows which https://github.com/timoxley/npm-which

dclear commented 6 years ago

requires a settings area to manage. Moving to v.5.