ddev / ddev-varnish

Varnish reverse proxy add-on for DDEV
Apache License 2.0
9 stars 10 forks source link

Add redirects for mailhog ports, fixes #10 #14

Closed skeemer closed 1 year ago

skeemer commented 1 year ago

This is one possible solution for fixing

This seemed the best option to not interfere with other addons.

skeemer commented 1 year ago

How do I make the test "install from release" pass without the PR being merged and released?

rfay commented 1 year ago

Just edit it out and then remember to fix :)

skeemer commented 1 year ago

So one PR to add the feature and a second PR to be added after the feature is released to fix the tests? That seems a bit convoluted.

rfay commented 1 year ago

Could you please manually test and review this @jedebois ?

rfay commented 1 year ago

Ping @jedubois