use `8142` as default port for HTTPS

ddev / ddev-xhgui

XHGui service for a DDEV project

Apache License 2.0

10 stars 7 forks source link

use `8142` as default port for HTTPS #32

Closed tyler36 closed 5 months ago

tyler36 commented 5 months ago

@simesy pointed out on slack that:

README HTTPS examples use port 8142
ddev status shows HTTPS using port 8143

This inconsistency needs to be resolved.

This PR updates the service and launcher command to use 8142 on HTTPS. 8142 is listed as the default port used on https://github.com/perftools/xhgui#installation-with-docker .

tyler36 commented 5 months ago

Need to keep an eye on #31 will need updating if this proceeds.

tyler36 commented 5 months ago

Do you think its better to change the port (this PR) or the docs?

DDEV services and addons generally use the default ports on HTTPS; so I went with logic here.

rfay commented 5 months ago

Default port on HTTPS is natural and normal. There is one exception (Solr) where HTTPS doesn't behave right for some reason, but best on all the others is HTTPS.

I think either way you go (README or this) is fine.