search

ddev / ddev-xhgui

XHGui service for a DDEV project
Apache License 2.0
12 stars 7 forks source link

Make add-on work w/o ddev-router, update tests #37

Closed stasadev closed 4 months ago

stasadev commented 4 months ago

The Issue

This add-on doesn't work in Gitpod.

How This PR Solves The Issue

In terms of functionality, this add-on is similar to https://github.com/ddev/ddev-phpmyadmin This PR contains recent fixes and improvements from ddev-phpmyadmin.

Manual Testing Instructions

Test it locally and in Gitpod.

Open in Gitpod

ddev get https://github.com/ddev/ddev-xhgui/tarball/20240718_stasadev_norouter
ddev restart
ddev xhgui

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

rfay commented 4 months ago

For more generality we may want to move to using the router on gitpod/codespaces.

tyler36 commented 4 months ago

Hmmm ... not sure if If like the restart in the health checks. I know it removes duplication, but personally, I prefer it in the test body. That way:

If you prefer it in the health check, I guess I'm OK with that.

stasadev commented 4 months ago

If you prefer it in the health check, I guess I'm OK with that.

It was a simple copy-paste to match the code in ddev-phpmyadmin.

I like your arguments, so I reverted this change.

tyler36 commented 4 months ago

Works great! Thank you.

Test

  1. Click "Open in GItpod" link in description.

  2. Add PR via tarball.

    ddev get https://github.com/ddev/ddev-xhgui/tarball/20240718_stasadev_norouter

  3. Restart DDEV to apply addon.

    ddev restart

  4. Confirm site is working.

    ddev launch

  5. Configure Drupal umami following instructions in this repo's README.

  6. Start profiling.

    ddev xhprof

  7. Navigate site to generate a couple of profile reports.

  8. Confirm launch command opens xhgui.

    ddev xhgui

image