ddev / ddev-xhgui

XHGui service for a DDEV project
Apache License 2.0
10 stars 7 forks source link

Fix installation, startup, and other first-run errors #4

Closed deviantintegral closed 1 year ago

deviantintegral commented 1 year ago

@tyler36 good job nerdsniping me by writing a readme that looked like the initial setup would work out of the box!

This PR replaces https://github.com/tyler36/ddev-xhgui/pull/2 as it turns out there was more to do then just fix the configuration.

This branch can be tested with:

ddev get https://github.com/deviantintegral/ddev-xhgui/tarball/fix-startup
tyler36 commented 1 year ago

Thank you for this. I haven't had a chance to get back to this and it looks like you got it in a working state.

tyler36 commented 1 year ago

I appologize. When I approved this PR, I merged it when I intended to squash/merged, I've tried to using to hacker to add you back as author. Not sure if it was successful where it counts.

deviantintegral commented 1 year ago

No big deal @tyler36 ! Just glad to get it in.