ddev / ddev-xhgui

XHGui service for a DDEV project
Apache License 2.0
12 stars 7 forks source link

Improve docs #5

Closed tyler36 closed 1 year ago

tyler36 commented 1 year ago

@rfay If you have time, could you give this the once over?

rfay commented 1 year ago

Sure, it will probably be a day or two.

rfay commented 1 year ago

This is the kind of detail I was expecting to see (what ddev xhprof provides by default)

image
tyler36 commented 1 year ago

This is the kind of detail I was expecting to see (what ddev xhprof provides by default)

The kind of detail is available but you need to click through on a specific request. image

image

rfay commented 1 year ago

Thanks for showing me where to click, I clicked on the run, but not on the method. It's probably a good thing to add to the README? Or perhaps that's just the job of the upstream docs.

tyler36 commented 1 year ago

Thanks for showing me where to click

The first time I got data into xhgui, I too was "underwhelmed"; it was pretty but where was all the good data?

tyler36 commented 1 year ago
tyler36 commented 1 year ago

Snuck in the helper command, ddev xhgui to launch (f321f431a75833e52470e4e0b94c60320e547467)

rfay commented 1 year ago

Test with ddev get https://github.com/tyler36/ddev-xhgui/tarball/20231106_drupal_settings

tyler36 commented 1 year ago

I think there are enough good changes here to merge. This will make it much easier for people to start using this addon.

All of the documentation feedback was address, and there are issues opened for other implementaion points ( #11, #13 , #14 ).

Thank you for your help and review.