ddev / ddev

Docker-based local PHP+Node.js web development environments
https://ddev.com
Apache License 2.0
2.76k stars 602 forks source link

Remove deps from vendoring that no longer apply #13

Closed frodopwns closed 7 years ago

frodopwns commented 7 years ago

There are bound to be unused packages in the vendor directory at this point. Remove all the things!

beeradb commented 7 years ago

https://github.com/FiloSottile/vendorcheck may be a solution to this.

Reviewers: @beeradb

cyberswat commented 7 years ago

https://github.com/drud/drud-go/pull/40 should be merged before this is completed.

rfay commented 7 years ago

First usage of vendorcheck -u:

rfay@Randy-Air:~/go/src/github.com/drud/ddev$ vendorcheck -u
[!] unused vendored package: github.com/drud/ddev/vendor/cloud.google.com/go/storage
[!] unused vendored package: github.com/drud/ddev/vendor/github.com/Microsoft/go-winio
[!] unused vendored package: github.com/drud/ddev/vendor/github.com/aws/aws-sdk-go/service/s3/s3manager/s3manageriface
[!] unused vendored package: github.com/drud/ddev/vendor/github.com/davecgh/go-spew/spew
[!] unused vendored package: github.com/drud/ddev/vendor/github.com/docker/docker/pkg/longpath
[!] unused vendored package: github.com/drud/ddev/vendor/github.com/fsouza/go-dockerclient/testing
[!] unused vendored package: github.com/drud/ddev/vendor/github.com/gorilla/context
[!] unused vendored package: github.com/drud/ddev/vendor/github.com/inconshreveable/mousetrap
[!] unused vendored package: github.com/drud/ddev/vendor/github.com/kennygrant/sanitize
[!] unused vendored package: github.com/drud/ddev/vendor/github.com/pmezard/go-difflib/difflib
[!] unused vendored package: github.com/drud/ddev/vendor/github.com/spf13/cobra/doc
[!] unused vendored package: github.com/drud/ddev/vendor/github.com/spf13/viper/remote
[!] unused vendored package: github.com/drud/ddev/vendor/github.com/stretchr/objx
[!] unused vendored package: github.com/drud/ddev/vendor/github.com/stretchr/testify
[!] unused vendored package: github.com/drud/ddev/vendor/github.com/stretchr/testify/suite
[!] unused vendored package: github.com/drud/ddev/vendor/golang.org/x/text/internal/gen
[!] unused vendored package: github.com/drud/ddev/vendor/golang.org/x/text/internal/triegen
[!] unused vendored package: github.com/drud/ddev/vendor/golang.org/x/text/internal/ucd
[!] unused vendored package: github.com/drud/ddev/vendor/google.golang.org/appengine
[!] unused vendored package: github.com/drud/ddev/vendor/google.golang.org/appengine/internal/socket
[!] unused vendored package: github.com/drud/ddev/vendor/google.golang.org/appengine/socket
[!] unused vendored package: github.com/drud/ddev/vendor/google.golang.org/appengine/urlfetch