Closed stasadev closed 3 weeks ago
Download the artifacts for this pull request:
Looks good to me! What do you think @bmartinez287 ?
Looks good.
@bmartinez287 OK even with the lack of direct dark variants? Seems like it should be fine to me.
Yeah, it should be fine even without the dark variants. It's always nice to have but providing our own adds extra maintenance and they might release those at any point. I'm surprised they don't have them documented since they use light and dark modes extensively. https://docs.github.com/en/codespaces/setting-up-your-project-for-codespaces/setting-up-your-repository/facilitating-quick-creation-and-resumption-of-codespaces#creating-an-open-in-github-codespaces-badge
The Issue
How This PR Solves The Issue
I tried https://pullrequestbadge.com/ from https://github.com/gitpod-io/gitpod/issues/19519#issuecomment-2093438752, but decided to do something else.
Found these:
Manual Testing Instructions
I did not find the light/dark variants for the images:
Light background:
Dark background:
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes