ddev / ddev

Docker-based local PHP+Node.js web development environments
https://ddev.com
Apache License 2.0
2.43k stars 579 forks source link

build: show badges for Gitpod and GitHub Codespaces in PRs #6151

Closed stasadev closed 3 weeks ago

stasadev commented 4 weeks ago

The Issue

How This PR Solves The Issue

I tried https://pullrequestbadge.com/ from https://github.com/gitpod-io/gitpod/issues/19519#issuecomment-2093438752, but decided to do something else.

Found these:

Manual Testing Instructions

I did not find the light/dark variants for the images:

Light background:

image

Dark background:

image

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

github-actions[bot] commented 4 weeks ago

Download the artifacts for this pull request:

rfay commented 4 weeks ago

Looks good to me! What do you think @bmartinez287 ?

bmartinez287 commented 4 weeks ago

Looks good.

rfay commented 4 weeks ago

@bmartinez287 OK even with the lack of direct dark variants? Seems like it should be fine to me.

bmartinez287 commented 3 weeks ago

Yeah, it should be fine even without the dark variants. It's always nice to have but providing our own adds extra maintenance and they might release those at any point. I'm surprised they don't have them documented since they use light and dark modes extensively. https://docs.github.com/en/codespaces/setting-up-your-project-for-codespaces/setting-up-your-repository/facilitating-quick-creation-and-resumption-of-codespaces#creating-an-open-in-github-codespaces-badge

Screenshot 2024-05-04 at 8 29 43 AM