fix: retrieve Drupal 11 sqlite3 packages from snapshot.debian.org - Githubissues

ddev / ddev

Docker-based local PHP+Node.js web development environments

https://ddev.com

Apache License 2.0

2.47k stars 585 forks source link

fix: retrieve Drupal 11 sqlite3 packages from snapshot.debian.org #6175

Closed rfay closed 1 month ago

rfay commented 1 month ago

The Issue

Suddenly we're not able to support sqlite/libsqlite 3.45.1 because it's gone from the repo we were pulling it from, so Drupal 11 startup fails.

How This PR Solves The Issue

Pull from snapshot.debian.org

I do wonder if we should only grab the 3.45 sqlite if they have omit_containers[db].

I don't understand why we didn't catch this in latest test on master (https://github.com/ddev/ddev/actions/runs/9035899711/job/24831603173) unless they just removed the package between the time that started and when I was testing. (Search for "DdevFullSiteSetup for TestPkgDrupal11"). Code is in https://github.com/ddev/ddev/blob/a96ab265933cc9c94c7533740fd40d78add0ccc5/pkg/ddevapp/ddevapp_test.go#L2221-L2232

I did manually test TestDdevFullSiteSetup with drupal11 on master and it failed there and succeeds here.

Manual Testing Instructions

Start a d11 project

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

github-actions[bot] commented 1 month ago

Download the artifacts for this pull request: