search

ddev / github-action-setup-ddev

Set up your GitHub Actions workflow with DDEV
GNU General Public License v3.0
35 stars 7 forks source link

Fix #23: Use node20 runner instead of EOL node16 #24

Closed penyaskito closed 7 months ago

penyaskito commented 7 months ago

The Issue

How This PR Solves The Issue

Use node20 runner instead of EOL node16

Manual Testing Instructions

No warns should be given.

Automated Testing Overview

See https://github.com/ddev/github-action-setup-ddev/actions/runs/8180622047. It has node 16 warnings. This PR actions shouldn't have any.

Related Issue Link(s)

https://nodejs.org/en/blog/announcements/nodejs16-eol

Release/Deployment Notes

rfay commented 7 months ago

I started the tests and added you as member of the ddev org, which I think will let you restart tests as well as not have to have somebody else start them.

penyaskito commented 7 months ago

No warns on https://github.com/ddev/github-action-setup-ddev/actions/runs/8184388405 vs https://github.com/ddev/github-action-setup-ddev/actions/runs/8180622047, so this is good to go IMHO.

davereid commented 7 months ago

I actually wonder if we need to update the @types/node dependency to ^20 in this PR as well.

penyaskito commented 7 months ago

@davereid Good catch! Let's see if I did that correctly.