search

ddev / github-action-setup-ddev

Set up your GitHub Actions workflow with DDEV
GNU General Public License v3.0
35 stars 7 forks source link

Fix #27: Update installation of ddev #28

Closed tomasnorre closed 6 months ago

tomasnorre commented 6 months ago

This is my first PR in a GHA done with JavaScript, so please let me know if something doesn't follow the best practises.

The Issue

There is a warning on how ddev is installed, this removes this warning

Manual Testing Instructions

There is no test information, only check that there are no warning regarding installing the ddev package. If not fixed, the warning would be similar to: 

W: https://apt.fury.io/drud/dists/*/InRelease: Key is stored in legacy trusted.gpg keyring (/etc/apt/trusted.gpg), see the DEPRECATION section in apt-key(8) for details.

Related Issue Link(s)

27

Release/Deployment Notes

No changes needed besides merging.

jonaseberle commented 6 months ago

This looks good to me and our tests are happy. Thank you @tomasnorre!

I'll look at https://github.com/ddev/github-action-setup-ddev/pull/31 and tag a release today.