ddevault / Craft.Net

(Unmaintained, see TrueCraft) Minecraft server, client, and etc for .NET
MIT License
228 stars 64 forks source link

Encryption enabled = wait for ever #145

Closed hellow554 closed 11 years ago

hellow554 commented 11 years ago

Hi Drew,

(on mono) when you enable encryption and then try to login it stops working. It sends a 0xCD with empty payload and then the encrypted 0x01 packet and then stops working cause it waits for more packets.

I don't know the exact line (I'm not at home) but you should investigate this.

ddevault commented 11 years ago

https://bugzilla.xamarin.com/show_bug.cgi?id=9247

I am aware of this bug and I am actively seeking a solution. I will likely be falling back to Bouncy Castle on Mono.

hellow554 commented 11 years ago

Could be possible. I knew that an old implementation of mine was working... hmmm, dunno ;)

ddevault commented 11 years ago

If you have something that works, a pull request would be very welcome.

ddevault commented 11 years ago

Fixed in 10de619714f74e4e6b8c2becc5fa2b3bf786d002

hellow554 commented 11 years ago

This bug (the mono one) should be fixed with the newest release of mono 3.0.3 I will test this too. Your implementation works like a charm ;)

pdelvo commented 11 years ago

I hope so!