search

ddevault / Craft.Net

(Unmaintained, see TrueCraft) Minecraft server, client, and etc for .NET
MIT License
228 stars 64 forks source link

Implement OnGround tracking for C.N.Client.MinecraftClient #196

Closed sapphire-arches closed 10 years ago

sapphire-arches commented 10 years ago

Implements OnGround tracking so bukkit will let us fall.

ddevault commented 10 years ago

Thanks, @bobtwinkles

@punkkeks not worth closing the PR over, imo

hellow554 commented 10 years ago

@SirCmpwn you're right. But I think it should be mentioned and fixed. I don't like that kind of style if (cond) return true else return false

I think is is stupid and does not support the reading and understanding of the code.

ddevault commented 10 years ago

I agree that it's not really great, but it's not that bad.

BoundingBox is nullable because some blocks (like air) don't have one.

Feel free to clean this up in a second PR. I don't mind some of the style choices here, but I'm willing to merge something that changes them.

sapphire-arches commented 10 years ago

@punkkeks The second if (cond) return true else return false lines are left over from when there was more complex logic, I probably should have cleaned it up. The first I have no excuse for