Support #68, #79, #80, #83 and fixes #60, #78

[KingArthurLV]

Added support for:

• FS22_AmericanFlatbedPack
• FS22_RollandRPLCH
• FS22_AW362_CaboverR
• FS22_LizardF600

Fixes for:

• FS22_LizardLT679SmallLogTrailer
• FS22_Komatsu_Forwarder_Pack

Everything tested with various sizes of palets, bales and wood logs. In testing used only FS22_UniversalAutoload v.1.3.3.0 and FS22_EasyDevControls v.1.3.0.2

[KingArthurLV]

I have quastion - if I use isBaleTrailer="true" does enableSideLoading="true" enableRearLoading="true" are affecting it or it is redundant? If it is redundant, I will remove it from pull.

[ddewar]

Bale trailer and side/rear loading are different features. Both should be declared. If both are used.

[ddewar]

Thank you very much for this PR. Looks like good stuff. I'm going to hold off merging it for a few days here. We have an updated UALAddon version with Giants right now. So just waiting to see what they do with that before pushing more vehicles to the repo.

[KingArthurLV]

You are welcome! Sure, I understand, lets give Giants time to do their thing 😃 I will keep make updates.

[KingArthurLV]

Added suport for:

• FS22_Forest_Platform

[KingArthurLV]

Added support for:

• FS22_ITRTwo

Fix for:

• FS22_Bailey_Bale_Pallet_Trailer

[KingArthurLV]

Added support for:

• Marshall BC/32
• Junkkari J16-J18

[KingArthurLV]

Added support:

• FS22_Old20FootBaleTrailer
• FS22_manTGX_26640_strawbale
• FS22_lizard_rp03
• FS22_camara_rp03

Fix for:

• FS22_lizard_sp03_crossplay
• FS22_camara_sp03

[ddewar]

Hey there, do me a favor and hold off on adding anything else to this PR. I've started checking configs and testing these. Let's get these in and if you do anymore let's get them in a new PR.

[KingArthurLV]

Hey there, do me a favor and hold off on adding anything else to this PR. I've started checking configs and testing these. Let's get these in and if you do anymore let's get them in a new PR.

Sure man! No problem. Let me know if there is something I need to fix or adjust in this PR.

Also I would like to purpose to create one thing in this repo - guidlines for creating support. Because what I noticed, that different people have different opinions on loading sizes, especialy height. I took facts as my guide. I studied what are real world parameters for different loads and tok it as general rule. As well I allowed some small adjusments to acomodate maximum reasonable amount of items in loading.

[ddewar]

Looking good so far. First thing I've run into, maybe we shouldn't support UAL on the F600 that has a capacity?

Also, width on that configuration is a little high. Pallets are getting suck in the tipper sides.

[KingArthurLV]

Hi! I mean, I also thought about it, but at the same time, that is tipper with low boards, so in real world situation, truck would be used as pallet hauler as well. But I also understand that because of game limitations, people would be able lead bulk alongside pallets. My personal opinion is giving players maximum real-world gameplay and give freedom to choose what to load in the truck using convenience of Autoload.

About width, I will check that out, I believe, I hoped that flatbed and low board tipper was with same width. Probably will need to make additional support line for that.

[KingArthurLV]

I checked it, so "pallet" itself is not clipping into tipper boards, but because each pallet has extra 0.5 (dont know exact number) xyz border dimension, loading size needs to be a bit wider, to actually put 2 pallets horizontally, to maximize pallets capacity.

I actually would love to know, why exactly all items have extra blank space. To not cause collisions?

[KingArthurLV]

And maybe we can make suggestion to FS22_UniversalAutoload mod to create additional check to prevent player to load pallets if tipper for example is filled?

[ddewar]

I checked it, so "pallet" itself is not clipping into tipper boards, but because each pallet has extra 0.5 (dont know exact number) xyz border dimension, loading size needs to be a bit wider, to actually put 2 pallets horizontally, to maximize pallets capacity.

I actually would love to know, why exactly all items have extra blank space. To not cause collisions?

Yeah, I think with a lot of base game pallets Loki left a little wiggle room to avoid clipping. I'm not sure that will always be the case for all modded pallets though. I try to use the outlines as the strict rules, even if the pallets themselves do not clip.

[ddewar]

And maybe we can make suggestion to FS22_UniversalAutoload mod to create additional check to prevent player to load pallets if tipper for example is filled?

Not a bad idea, but the problem really comes in when you autoload something like a pallet of seeds. When it gets put onto the trailer it starts unloading and that's when it starts causing problems. I'm not against leaving it and letting the user deal with it if they try loading non-production pallets, but for the most part I have avoided trailers with capacity to avoid that issue. Especially, if the trailer has another version that can be without capacity like in this case.

[ddewar]

I'm a little concerned about the length on the Marshall trailer. I'm running into some colliding issues.

Any reason you wanted the longer length?

Also, baleHeight="3.8" might be a little top heavy for those trailers. See any issues with that on your end?

[ddewar]

Some funkiness with the Junkkari. But I think it's good enough. Run into any issues with it?

[ddewar]

The other flatbed on the Junkkari looks like it needs a different length and offset. It clips through the front when added and goes too far off the back.

[ddewar]

20FT Bale Trailer has a little too much length. Causing some stacking issues

Also worth noting, we should add a slectedConfig setting to only add it to the non-autoload version on that trailer.

[ddewar]

TGX Man Straw Bale mod might need two things:

1. Only limit it to the config without autoload
2. The loading zone needs to be moved back just a tiny bit. Some pallets are getting stuck and flying all over the place

[KingArthurLV]

Nice, Dan is doing some testing :)

Okey first about bale height and height overall. I dig up 2 numbers from real world truckload height in US and EU. In EU it is 4,5m and in US 4,3m (14 feet) including trailer height from the ground. I took bale height 3,8m because it is minimum height to allow load 2 layers of 1,8m bales. For pallets I am thinking to use max 3 layers of highest pallets which is 1,3m (wool) and 1,2m (cereal, flour, sugar). At the same time, I believe it would make sense to also use correct proportions. Let’s say trailer length is less than 1,3 x 3 = 3,9m, so then height should not be more than trailer lenght.

Basically, this is what I wrote before, that I think it would really help, if we could come up with some exact guidelines and make it as standard.

[KingArthurLV]

Some funkiness with the Junkkari. But I think it's good enough. Run into any issues with it?

I tested it with different sizes of pallets and did not have an issue. But I have an idea, that maybe we can make suggestion to FS22_UniversalAutoload mod, to have option to create different loading areas for different container type. Because that would really make sense and we will be able to really make custom loading spaces for bales and pallets separate. I know it would create much more work in our end, but it would make much pleasant gaming experience and use of FS22_UniversalAutoload.

And I understand that I am marching with all these ideas and changes, and You don’t know me and my skills and need to verify if I am legit :). That is why I am making an effort to it. Secondly, I really like this game and the community around it, but also, I see so much potential and some "holes" that can be improved, patched etc.

[KingArthurLV]

And maybe we can make suggestion to FS22_UniversalAutoload mod to create additional check to prevent player to load pallets if tipper for example is filled?

Not a bad idea, but the problem really comes in when you autoload something like a pallet of seeds. When it gets put onto the trailer it starts unloading and that's when it starts causing problems. I'm not against leaving it and letting the user deal with it if they try loading non-production pallets, but for the most part I have avoided trailers with capacity to avoid that issue. Especially, if the trailer has another version that can be without capacity like in this case.

Okey, I understand and that makes sense as well. So, I will put it as a guideline in my draft that I am preparing. General rule - no autoload for bulk item tippers, so there is no confusion.

BUT if could make suggestion to Loki create one more parameter for each loading area to set containerType which is laready defined in ContainerTypes.xml, we could still use this tipper, just limit it for bales and/or liquid tanks etc.

[KingArthurLV]

TGX Man Straw Bale mod might need two things:

1. Only limit it to the config without autoload
2. The loading zone needs to be moved back just a tiny bit. Some pallets are getting stuck and flying all over the place

I see that I need to improve my testing ground, most of the time I load same material type pallets at once, not random. I will retest all, to make sure that there are no funky things happening.

[ddewar]

TGX Man Straw Bale mod might need two things:

1. Only limit it to the config without autoload
2. The loading zone needs to be moved back just a tiny bit. Some pallets are getting stuck and flying all over the place

I see that I need to improve my testing ground, most of the time I load same material type pallets at once, not random. I will retest all, to make sure that there are no funky things happening.

The ualAddPallets command will do the randomization for you. Super helpful!

[ddewar]

Some funkiness with the Junkkari. But I think it's good enough. Run into any issues with it?

I tested it with different sizes of pallets and did not have an issue. But I have an idea, that maybe we can make suggestion to FS22_UniversalAutoload mod, to have option to create different loading areas for different container type. Because that would really make sense and we will be able to really make custom loading spaces for bales and pallets separate. I know it would create much more work in our end, but it would make much pleasant gaming experience and use of FS22_UniversalAutoload.

And I understand that I am marching with all these ideas and changes, and You don’t know me and my skills and need to verify if I am legit :). That is why I am making an effort to it. Secondly, I really like this game and the community around it, but also, I see so much potential and some "holes" that can be improved, patched etc.

All good, you're making some good suggestions. Loki and I just haven't had much of a need for too many advanced features without making it really tough to manage as a user. I don't think we need zones for bales vs pallets in these situations. The big thing is just adjusting the zones on the trailers to always match the planes that are being loaded. I know sometimes, especially with bales, you can get away with oversizing them, but most of the time it just comes back to bite us when using pallets. The only time I try to do oversizing is when it is a log trailer and we can get to that next full meter mark.

As far as height goes, I don't mind your suggestion on 3.8 for baleHeights. I find it very frustrating to not be able to stack 2 180 round bales, but when it comes to pallets, I get lots of issues on these bigger heights. Remembering that by default UAL will stack starting at the front up to max height, sometimes this results in very top-forward heavy loading. So, for the most part, I have been making trailers support about 2 high for the pallets. Anything over that was getting very tippy. I always encourage users who want more height to copy the default config into their local UAL settings and increase the height.

My suggestion would be to check your loading zones for:

1. Height causing high pallet stacking (Bales are okay)
2. The loading zones should not extend past the loading bed.

To me it looked like these conifgs are all 90% there and I really appreciate the work you've put into them. Honestly, might need to start using some of these trailers in my own save games :)

[ddewar]

And maybe we can make suggestion to FS22_UniversalAutoload mod to create additional check to prevent player to load pallets if tipper for example is filled?

Not a bad idea, but the problem really comes in when you autoload something like a pallet of seeds. When it gets put onto the trailer it starts unloading and that's when it starts causing problems. I'm not against leaving it and letting the user deal with it if they try loading non-production pallets, but for the most part I have avoided trailers with capacity to avoid that issue. Especially, if the trailer has another version that can be without capacity like in this case.

Okey, I understand and that makes sense as well. So, I will put it as a guideline in my draft that I am preparing. General rule - no autoload for bulk item tippers, so there is no confusion.

BUT if could make suggestion to Loki create one more parameter for each loading area to set containerType which is laready defined in ContainerTypes.xml, we could still use this tipper, just limit it for bales and/or liquid tanks etc.

Good rule of thumb there.

Maybe worth opening a suggestion on the UAL GitHub for how to handle bulk trailers. I agree, they can make things messy if you're not careful as is!

[KingArthurLV]

I am retesting all commits, I think today will do it all.

I made also suggestion to UAL: https://github.com/loki79uk/FS22_UniversalAutoload/issues/177

[ddewar]

I am retesting all commits, I think today will do it all.

I made also suggestion to UAL: loki79uk/FS22_UniversalAutoload#177

How we doing on this? Am I good to look at it again?

[KingArthurLV]

I'am half way trough. Made some adjustments. Unfortunatley I was 2 days out of town, now I am back. Will try today/tomorrow finish it. Is it okey if it will be one commit for all adjustments?

[ddewar]

Iam half way trough. Made some adjustmwnts. Unfortunatley I was 2 days out of town, now I am back. Will try today/tomorrow finish it. Is it okey if it will be one commit for all adjustments?

All good here with one commit. No rush, just ping me whenever I should look again.

[KingArthurLV]

Hi! Finaly got some free time from IRL to finish up testing and fixing issues. Check it out @ddewar ;)

[ddewar]

Trying to finish this review up tonight. Please do me a favor and remove any changes to supportedMods.md when you get a chance. It's auto generated, and we won't worry about it.

[KingArthurLV]

Ou sorry about that, did not know that. I will do that. You need me to remove all changes I made in that file, or just changes that I made in secondary testing?

[ddewar]

Ou sorry about that, did not know that. I will do that. You need me to remove all changes I made in that file, or just changes that I made in secondary testing?

The file completely. Just need the supported vehicles file.

[ddewar]

Hey, just letting you know, I'm about halfway through and these are looking pretty good. The lower stack heights for pallets is making it a little more manageable. We'll have to see if we get any complaints with the 3 high of almost every pallet, but looks good to me.

[ddewar]

Okay, just about there, everything is looking great. If you can, test the Marshall trailer with 125cm round bales. I think there's a collision on the back we are hitting. Might have to shorten that one just a touch.

[KingArthurLV]

Just checked, are You sure problem is with 125 cm? For me seems perfect.

[ddewar]

Just checked, are You sure problem is with 125 cm? For me seems perfect.

Ah, try stack loading. My tests run in stack first.

[ddewar]

Just checked, are You sure problem is with 125 cm? For me seems perfect.

PS. I love how that trailer looks with horizonal loading.

[KingArthurLV]

Hehe, I actually never tested with vertical loading, since I love bales stacking horizontal and didn’t even crossed my mind to check that also :DD My bad, everybody has own taste :) I will fix it right away, but is it possible to do it next commit after this PR? I just have already prepared hefty changes, and don’t want to mess it up now. I will post it as soon You accept this one.

[ddewar]

Hehe, I actually never tested with vertical loading, since I love bales stacking horizontal and didn’t even crossed my mind to check that also :DD My bad, everybody has own taste :) I will fix it right away, but is it possible to do it next commit after this PR? I just have already prepared hefty changes, and don’t want to mess it up now. I will post it as soon You accept this one.

Yeah. we can file that as a "bug fix" after the PR is in. The other one I noticed a bit funky is the 20ft Bale Trailer. It doesn't actually collide, but I noticed the zone if a bit longer than it should be with a back support. Same thing, let's not change it now, but maybe someone can look into it later

[KingArthurLV]

Will do, I actually planning to go through all Supported list and check if there is anything to improve or optimize. I am an efficiency freak and love when everything is tidy and standardized. I just hope You will let me do that :D

BTW what is Your background? Programmer? What languafes You work with?

[ddewar]

One last question. Looks like on the Komatsu pack you removed the dynamic height axis? Was it note working anymore or just a preference?

<loadingArea offset="0 1.40 -3.45" width="2.70" height="0.6" length="5.0" heightAxis="AXIS_CRANE_TOOL3" noLoadingIfUnfolded="true"/>

[ddewar]

Happy to discuss standardizing and such. If you have a Discord reach out there, might be a little better.

Discord: ddewar#1716

[KingArthurLV]

Actually not remmber anymore, but I remmeber that trailer was messy to load. Will recheck. and make fixes if needed.

[KingArthurLV]

Happy to discuss standardizing and such. If you have a Discord reach out there, might be a little better.

Discord: ddewar#1716

Sended friend request.