applySchema can return a new DDF or modify it inplace

ddf-project / DDF

Distributed DataFrame: Productivity = Power x Simplicity For Scientists & Engineers, on any Data Engine

http://ddf.io

Apache License 2.0

168 stars 42 forks source link

applySchema can return a new DDF or modify it inplace #335

Closed Huandao0812 closed 8 years ago

Huandao0812 commented 8 years ago

Description and related tickets, documents

fix SchemaHandler line separator

Reviewers: @zkidkid

How to test

Describe how this PR is tested. In case manual testing is required, describe how to do so.

PR Progress

Make sure all checkboxes below are checked before merged

[ ] Branch is in format prefix/description (see this)
[ ] Merge check has no conflicts. PR checks passed.
[x] Code review is done.

Huandao0812 commented 8 years ago

@zkidkid you used the wrong line separator in your IDE, please make sure it is "\n"

dnsang commented 8 years ago

@hai-adatao please take note that Huan has added inPlace flag in this ApplySchema function, so we will remove it in PE. (because currently PE process mutate not DDF).

Huandao0812 commented 8 years ago

@hai-adatao @zkidkid the flag in PE api will be there, I just move the logic to DDF

hai-adatao commented 8 years ago

@zkidkid this PR has no UT, why merge this?

Huandao0812 commented 8 years ago

@zkidkid can you help add UT for this please