ddf-project / DDF

Distributed DataFrame: Productivity = Power x Simplicity For Scientists & Engineers, on any Data Engine
http://ddf.io
Apache License 2.0
167 stars 42 forks source link

binning API now can return a factor column or an integer one #350

Closed nhanitvn closed 8 years ago

nhanitvn commented 8 years ago

Description and related tickets, documents

Reviewers: @hai-adatao @phvu @Huandao0812

Breaking changes & backward compatible issues

How to test

Describe how this PR is tested. In case manual testing is required, describe how to do so.

PR Progress

Make sure all checkboxes below are checked before merged

hai-adatao commented 8 years ago

@nhanitvn can you help put all these tests in ddf-test/BinningHandlerBaseSuite, and then implement spark test suite instead? Check out JoinHandlerBaseSuite and JoinHandlerSuite for an example. Also, would appreciate if you take a look at the tests in ddf-test/BinningHandlerBaseSuite, they're all ignored, if they're not valid anymore please help remove it, or refactor it otherwise.

hai-adatao commented 8 years ago

Let's try to get this in 1.4.17