ddiakopoulos / libnyquist

:microphone: Cross platform C++11 library for decoding audio (mp3, wav, ogg, opus, flac, etc)
BSD 2-Clause "Simplified" License
536 stars 64 forks source link

mpc mono crash #13

Closed r-lyeh-archived closed 8 years ago

r-lyeh-archived commented 8 years ago

Hey there,

Just giving a try on the library. Nice work so far!

It seems to crash here with test_data\ad_hoc\44_16_mono.mpc. Stereo mpc is fine though. Does it work on your machine :tm: ? :)

ddiakopoulos commented 8 years ago

Hmm. With what compiler? I just tried in XCode 7 + VS 2015 and the mono mpc file was ok.

r-lyeh-archived commented 8 years ago

vs2013, but I was using my own build script. I'll trace the crash and let you know!

r-lyeh-archived commented 8 years ago

Aha well, it is a heap corruption issue (probably when inflating d->samples during mpc_demux_decode) and it only happens in 64-bit builds. More info soon

ddiakopoulos commented 8 years ago

Investigated for 45 mins this morning with no luck. Probably an off by one error will reveal itself after 20 hours of debugging.

ddiakopoulos commented 8 years ago

Let me know if 031d94497b07f8195cc6e26be9e327c3d0fcd42f fixes it for you

r-lyeh-archived commented 8 years ago

woohoo :D perfect!