ddiakopoulos / libnyquist

:microphone: Cross platform C++11 library for decoding audio (mp3, wav, ogg, opus, flac, etc)
BSD 2-Clause "Simplified" License
540 stars 65 forks source link

modplug decoder: multichannel + midi support #16

Closed r-lyeh-archived closed 8 years ago

r-lyeh-archived commented 8 years ago

Hey there Dimitri,

Let me know if you are interested in this PR.

I've bundled the modplug library into libnyquist.

Modplug is a PD licensed solution to load multichannel music (mod, s3m, xm, it...) It also can play MIDI files and a wide range of WAVs. MIDI files (and .abc files) require the sound patches located in pat/ folder: these samples are either PD or GPL licensed.

Most if not all of the work came from @JariKomppa 's Soloud repo, so kudos to him :)

r-lyeh-archived commented 8 years ago

Btw, you'd have to update the project files like we did last time

r-lyeh-archived commented 8 years ago

ping @ddiakopoulos :)

ddiakopoulos commented 8 years ago

So I want to merge this but that folder of binary patterns is killer: both 11mb and with some of that content GPL? Ack!

r-lyeh-archived commented 8 years ago

lol It's an optional folder after all. I can remove the folder, but users will have to figure out how to recreate the soundpatches to play the MIDI songs.

edit: I'll update the README, remove the folder and update the PR during the day

r-lyeh-archived commented 8 years ago

@toread https://musescore.org/en/handbook/soundfont

r-lyeh-archived commented 8 years ago

ok, ready :D

ddiakopoulos commented 8 years ago

:+1: will merge this weekend

r-lyeh-archived commented 8 years ago

woohoo :+1:

r-lyeh-archived commented 8 years ago

Hey Dimitri,

I've added some more info on midi exporting and soundfont conversion (btw, regarding to the GPL timidity alternatives, the Fluid R3 is a good (and unique fully MIT licensed) soundfont, but it gets close to the gigabyte once converted to .pat, so it's better to have it apart from the repo :D)

Hope everything gets clearer from now

ddiakopoulos commented 8 years ago

Sorry this took so long :sweat_smile:

r-lyeh-archived commented 8 years ago

xD