search

ddiakopoulos / libnyquist

:microphone: Cross platform C++11 library for decoding audio (mp3, wav, ogg, opus, flac, etc)
BSD 2-Clause "Simplified" License
534 stars 64 forks source link

Populate the PUBLIC and PRIVATE interface of libnyquist #38

Closed ArthurSonzogni closed 5 years ago

ArthurSonzogni commented 5 years ago

When linking against libnyquist:

Along the way, update the linkage of the examples, it was made PUBLIC unnecessarily, it is an executable, it won't be linked against another target.

ArthurSonzogni commented 5 years ago

Hi,

First, thanks for making this library! It seems to works very well! Could you please take a look?

ArthurSonzogni commented 5 years ago

I added one more fix. Please take a look.

ArthurSonzogni commented 5 years ago

Hi, Do you have any update on this pull request?

ddiakopoulos commented 5 years ago

@ArthurSonzogni LTGM!