ddiakopoulos / libnyquist

:microphone: Cross platform C++11 library for decoding audio (mp3, wav, ogg, opus, flac, etc)
BSD 2-Clause "Simplified" License
534 stars 64 forks source link

Fixes ddiakopoulos/libnyquist#42 #43

Closed phniix closed 4 years ago

phniix commented 4 years ago

This aids in rethrowing exceptions from callers wanting to:

where std::exceptions are not raised by the catch on: https://github.com/phniix/libnyquist/blob/97d71768ef1fda423368bed87c090afbcfd1df81/src/Common.cpp#L135

-- Please consider these solutions to be inline with f94005c39885d2b66b5f579232b4d6d295636a66 I'm less fussed about the wording that gets sent to std::cerr. There are a number of failures from the decoder being propagated to the caller, that might be very helpful to be sent up, rather than swallowed up.

ddiakopoulos commented 4 years ago

Looks good to me. Thanks for your contribution!

phniix commented 4 years ago

Thank you!